Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AD Review of Signatures (Editorial) #2379

Merged
merged 10 commits into from
Jan 27, 2023
Merged

AD Review of Signatures (Editorial) #2379

merged 10 commits into from
Jan 27, 2023

Conversation

jricher
Copy link
Contributor

@jricher jricher commented Jan 19, 2023

Collects editorial comments of AD-reviewed signatures draft.

Closes #2371
Closes #2364
Closes #2368
Closes #2333
Closes #2330

@richanna
Copy link
Contributor

Changes look good to me, but the editor's copy build failed.

@jricher
Copy link
Contributor Author

jricher commented Jan 20, 2023

The failure seems to be in the rfc-http-validate tooling. This isn't failing on any other branch, so I'm not sure what's going on here to be honest. @martinthomson @mnot am I missing something? I thought we could use the http-message tag on message fragments, but that seems to be what's breaking from the build log here. It builds fine locally.

Nevermind, it seems the change to the trailing-space examples is what broke it. I removed the http-message tag from that one and it builds fine now. There really should be a better way to indicate a trailing space in a way the document tooling doesn't destroy.

Co-authored-by: Martin Thomson <mt@lowentropy.net>
@jricher jricher merged commit 5f84f81 into main Jan 27, 2023
@jricher jricher deleted the ad-review-editorial branch January 27, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants