client-cert: AD review feedback #2406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2023JanMar/0088.html and some minor editorial updates
…ay not being just a draft
MikeBishop
approved these changes
Feb 20, 2023
| @@ -323,14 +323,14 @@ from the TTRP). A TTRP MUST sanitize the incoming request before forwarding it | |||
| on by removing or overwriting any existing instances of the fields. Otherwise, | |||
| arbitrary clients can control the field values as seen and used by the backend | |||
| server. It is important to note that neglecting to prevent field injection does | |||
| not "fail safe" in that the nominal functionality will still work as expected | |||
There was a problem hiding this comment.
I suspect this was correct before; "fail safe" is a verb, where "fail-safe" would be an adjective or used as a noun.
Co-authored-by: Mike Bishop <mbishop@evequefou.be>
b---c
commented
Feb 21, 2023
|
thanks Mike, nits have been addressed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AD review feedback (thread at https://lists.w3.org/Archives/Public/ietf-http-wg/2023JanMar/0088.html) and some minor editorial updates