[connect-tcp] Discuss limits of multiprotocol templates #2720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| {: title="Example multipurpose template for a combined TCP, UDP, and IP proxy and DoH server"} | ||
| {: title="Example multipurpose template that allows the client to infer support for TCP, UDP, and IP proxying, and for DNS over HTTPS"} | ||
|
|
||
| To allow correct inference of the proxy's capabilities, multipurpose templates for general use MUST only contain variable names specified by the proxy's supported standards. Note that the "connect-ip" protocol has no mandatory variable names, so a proxy's support for "connect-ip" cannot always be inferred from the template's contents. |
There was a problem hiding this comment.
This statement requires updating RFC 9298, because it adds a new requirement on an implementation that only supports RFC 9298 and 9484. But more importantly, I'm not sure that requirement is a good idea. I'd rather find capabilities through discovery (e.g., draft-schwartz-masque-access-descriptions or draft-pauly-intarea-proxy-config-pvd) rather than inference.
There was a problem hiding this comment.
Yeah — the feedback in the PvD document was to make the types more explicit and not just rely on the implicit interpretation of the template. Worth more discussion, I think.
|
Closing in favor of #2736 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2713