Tune HTTP examples #421
Merged
Tune HTTP examples #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
reschke
commented
Nov 17, 2017
reschke
commented
- add type
- consistently indent
- trailing lines for requests
- add mandatory Host header fields
craigpratt
reviewed
Nov 25, 2017
| HEAD /resource HTTP/1.1 | ||
| Host: example.com | ||
| Range: bytes=0- | ||
|
|
There was a problem hiding this comment.
Do you think the blank lines at the end of the examples are really necessary? (Presume the intent is to show the terminating \n\n?)
There was a problem hiding this comment.
We do it in the base specs as well...
There was a problem hiding this comment.
Good enough reason for me. Consistency is good....
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.