Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ben's comments #645

Merged
merged 5 commits into from
Jun 27, 2018
Merged

Ben's comments #645

merged 5 commits into from
Jun 27, 2018

Conversation

martinthomson
Copy link
Contributor

@kaduk had a few comments in the review of this that are easy to solve.

kaduk
kaduk approved these changes Jun 5, 2018
View reviewed changes
Copy link
Contributor

@kaduk kaduk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wtarreau
Copy link

wtarreau commented Jun 5, 2018

All changes are OK to me as well. Thanks!

kaduk
kaduk approved these changes Jun 5, 2018
View reviewed changes
Copy link
Contributor

@kaduk kaduk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

43d2c16 does a great job capturing the point that I made poorly off-list; thanks again!

@martinthomson martinthomson merged commit 9b34b99 into master Jun 27, 2018
@martinthomson martinthomson deleted the kaduk-ad-replay branch June 27, 2018 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaduk kaduk kaduk approved these changes

Assignees
No one assigned
Labels
replay
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@martinthomson @wtarreau @kaduk