Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SH] make Serialising an Item return a value #676

Merged
merged 3 commits into from
Aug 13, 2018
Merged

[SH] make Serialising an Item return a value #676

merged 3 commits into from
Aug 13, 2018

Conversation

phluid61
Copy link
Collaborator

@phluid61 phluid61 commented Aug 3, 2018

Serialised value wasn't getting appended to output

@mnot
Copy link
Member

mnot commented Aug 10, 2018

Would it be better to just have each of the steps before return their result?

@phluid61
Copy link
Collaborator Author

I did wonder that when writing it. Or make them all s/let value/let output. Or however you think looks best.

I probably should have just filed it as an Issue. 🤔

@phluid61
just return in each of the branches
bf9f478
@phluid61
make the final clause an 'Otherwise'
3fa4796 
This makes it absolutely clear that there should be no alternative
branch by this point.
@mnot mnot merged commit b051177 into httpwg:master Aug 13, 2018
@mnot
Copy link
Member

mnot commented Aug 13, 2018

👍

@phluid61 phluid61 deleted the serialise-item branch August 14, 2018 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@phluid61 @mnot