[SH] remove rogue 'Otherwise' from string parser #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnot
reviewed
Aug 10, 2018
| @@ -663,7 +663,7 @@ Given an ASCII string input_string, return an unquoted string. input_string is m | |||
| 3. Else, if char is DQUOTE, return output_string. | |||
| 4. Else, if char is in the range %x00-1f or %x7f (i.e., is not in VCHAR or SP), fail parsing. | |||
| 4. Else, append char to output_string. | |||
| 6. Otherwise, fail parsing. | |||
| 6. Unterminated string; fail parsing. | |||
There was a problem hiding this comment.
Maybe make this a tiny bit less terse -- e.g., "Fail parsing (due to the string being unterminated)."?
|
How's that? It looks kind of like the equivalent case in Parse Dict/Parse List, but more descriptive than it was. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.