Fix: #967. Clarify the _returned value_ expression. #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LPardue
reviewed
Oct 31, 2019
| ### Digest in both Request and Response. Field-values depends on representation metadata | ||
|
|
||
| The request contains a `Digest` header | ||
| calculated on the enclosed representation. |
There was a problem hiding this comment.
Here I would highlight the Accept-Encoding header and then reword the next paragraph slightly e.g.
"It also includes an Accept-Encoding: br header field that advertises the client supports brotli encoding"
draft-ietf-httpbis-digest-headers.md
Outdated
Comment on lines
601
to
604
| The `Digest` field-value in the response is different | ||
| from the one of the request | ||
| because we used `Accept-Encoding` to selected another | ||
| representation respect to the sent one. |
There was a problem hiding this comment.
Then reword this as something like:
"The response includes a Content-Encoding:br that indicates the selected representation is brotli encoded. The Digest field-value is therefore different compared to the request.
ioggstream
force-pushed
the
ioggstream-967
branch
from
c21c586
to
5e0ce7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Clarifies the "returned value" expression.
Fixes: #967