Options for SETTINGS_MAX_CONCURRENT_STREAMS violations #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinthomson
added a commit
that referenced
this pull request
Nov 30, 2014
Options for SETTINGS_MAX_CONCURRENT_STREAMS violations
bradfitz
added a commit
to bradfitz/http2
that referenced
this pull request
Dec 3, 2014
Choose the error code for violating SETTINGS_MAX_CONCURRENT_STREAMS depending on whether the peer should know better. See httpwg/http2-spec#649 and httpwg/http2-spec#652
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than just PROTOCOL_ERROR, allow REFUSED_STREAM.
REFUSED_STREAM is a more lenient error. It allows clients to retry requests. Servers might also set the GOAWAY stream number to a lower value if they upgraded.
Closes #649.