Allow custom mount path #106
Merged
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huacnlee
reviewed
Oct 16, 2023
with RuCaptcha.config.mount_path
Gao-Jun
force-pushed
the
add_mount_path
branch
from
05188ca
to
ec6c838
Compare
|
PR updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add the ability to custom RuCaptcha's mount path with RuCaptcha.config.mount_path.
In my project, I make a sub project of a domain and mount the project at
/foo, and I cannot deploy RuCaptcha to/rucaptcha.With this PR, I can mount it at
/foo/rucaptcha. And I think maybe some other projects would use this feature.在我的一个项目中，所有的应用都被要求都部署在
/foo下，所以我希望将RuCaptcha部署在/foo/rucaptcha。目前的配置文件无法支持这个操作，所以只能通过改 HTTP Server 配置的方式处理，或者 monkey patch (还需要在engine挂载前执行)，都比较复杂。所以，这个 PR 希望通过增加新的配置项mount_path来更加优雅地实现这个需求。