refactor: change router implementation to lua-radix-router for better performance #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vm-001
commented
Jan 13, 2024
| end | ||
|
|
||
| function M:add_route(method, absolute_path, handlers) | ||
| self.router:insert(method, absolute_path, handlers) | ||
| local path = absolute_path -- todo, converts gin style to openapi style. /users/:name -> /users/{name} |
There was a problem hiding this comment.
The convert_path func will like
local function convert_path(path)
path = string.gsub(path, ":([^/]*)", "{%1}")
path = string.gsub(path, "%*(%w*)", "{%*%1}")
return path
end
assert("/api/{name}/{id}" == convert_path("/api/:name/:id"))
assert("/api/{}/{*}" == convert_path("/api/:/*"))
assert("/api/{name}/{id}/{*path}" == convert_path("/api/:name/:id/*path"))
|
Thanks for merging this PR. I look at the master code: The matched argument can be omitted if the web framework doesn't need it. So you save a table allocation overhead in the request path, which pretty hot path. |
|
Thanks for the reminder, I will find ways to make relevant optimizations |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The rax based router is not efficient when it comes to the URL scenario. Only the partial path(before the first
:) is stored in radix tree, which means it may become a linear search in the worst scenario.See https://github.com/hanxi/lua-rax/blob/7c80520074c35d1afb99fc4698f6684c9575393d/rax.lua#L75.
Based on the benchamrks, the lua-radix-router is ~70x faster than rax based router in the GitHub API test suit. See benchmarks