Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for ECC keys #50

Closed
czocher opened this issue Mar 30, 2019 · 3 comments
Closed

Support for ECC keys #50

czocher opened this issue Mar 30, 2019 · 3 comments

Comments

@czocher
Copy link
Contributor

czocher commented Mar 30, 2019

Hello,
First of all thanks for all your hard work on the project, it's at least a time saver if not a lifesaver.
My problem is that the only SSL keys I have for my domain are not RSA keys but ECC keys. From what I know postfix support ECC keys by two config options:

smtpd_tls_eckey_file = smtpd-key-ecdsa.key
smtpd_tls_eccert_file = smtpd-cert-ecdsa.cert

The problem is, from what I see the main.dist.cf file accepts only RSA keys with the smtpd_tls_key_file and smtpd_tls_cert_file directive.

Is there any possibility for ECC key support to be added to the container too?

@huan
Copy link
Owner

huan commented Mar 30, 2019

Hello, thanks for like the project.

I believe it's do-able to support the ECC keys to the SMF container.

PR will be welcome. :-)

@czocher
Copy link
Contributor Author

czocher commented Mar 30, 2019

Testing it right now with a substituted configuration, I only changed smtpd_tls_key_file to smtpd_tls_eckey_file and smtpd_tls_cert_file to smtpd_tls_eccert_file and it seems to work fine. I'll check a few possibilities (mostly whether you can configure both ECC and RSA keys at the same time without causing postfix a lot of headache).
Gonna get back to you with a proper PR as soon as I test it thoroughly.

@czocher
Copy link
Contributor Author

czocher commented Mar 30, 2019

Okay the PR is ready: #51
Tested it on my setup, it doesn't throw any errors in the logs although the smtp.cert/key is missing, probably cause it sees the smtp.ec.key and smtp.ec.key as a replacement.
Thanks for the mention in the README, it made my day :D

@czocher czocher mentioned this issue Mar 30, 2019
@czocher czocher closed this as completed Mar 30, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants