Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatible with FileBox v1.x & v0.x: type v.s. boxType #73

Closed
huan opened this issue Nov 22, 2021 · 0 comments
Closed

Compatible with FileBox v1.x & v0.x: type v.s. boxType #73

huan opened this issue Nov 22, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@huan
Copy link
Owner

huan commented Nov 22, 2021

We have a breaking change between the FileBox v1.0 and v0.x:

FileBox v1.0:

1. `toJSON` format renamed `boxType` to `type`
2. `type()` has been changed to `type`
3. `version()` has been changed to `version`

This will break the compatibility between the JSON data exchange between those two versions.

Add a workaround to make all the versions to be happy.
@huan huan added the bug Something isn't working label Nov 22, 2021
huan added a commit that referenced this issue Nov 22, 2021
@huan
compatible with v0.x (#73)
9509d3b
huan added a commit that referenced this issue Nov 22, 2021
@huan
fix unit test (#73)
08e9d96
@huan huan mentioned this issue Nov 22, 2021
Closed
@huan huan closed this as completed Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@huan