Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to SnapDB #45

Closed
huan opened this issue Aug 13, 2019 · 4 comments
Closed

Switch to SnapDB #45

huan opened this issue Aug 13, 2019 · 4 comments

Comments

@huan
Copy link
Owner

huan commented Aug 13, 2019

SnapDb is a Simple & Robust LSM Powered Javascript key-value store with Zero dependencies with pure JavaScript implementation.

Switch to SnapDB will solve #43 and make the installation easy for the end-users who have no build tool installed.

@huan
Copy link
Owner Author

huan commented Aug 13, 2019

Some improvements need to be done before we can be able to switch:

  1. [feature request] add a generator for getAllKeys? only-cliches/snap-db#1
  2. Can we do ready() implicitly? only-cliches/snap-db#2

@only-cliches
Copy link

only-cliches commented Aug 16, 2019

Was reading through the code and noticed you guys needed a few other things.

// FIXME(huan): string for SnapDB only

* FIXME(huan): use better way to do this

I added support for any key types and a new .exists method in SnapDB 1.1.5, just released.

Just keep in mind even in any mode provided keys must be a string or number, everything else will be stringified before being saved to disk.

Hope that helps you guys out!

@huan
Copy link
Owner Author

huan commented Aug 17, 2019

Awesome! Thank you for the great improvement, will update the code later!

@huan huan reopened this Aug 17, 2019
huan added a commit that referenced this issue Aug 19, 2019
@huan
Copy link
Owner Author

huan commented Aug 19, 2019

We were able to get rid of all the as any in the code with the help from @ClickSimply.

Appreciate!

@huan huan closed this as completed Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants