Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Little confused about FlashStore.size #50

Closed
su-chang opened this issue Oct 18, 2019 · 3 comments
Closed

Little confused about FlashStore.size #50

su-chang opened this issue Oct 18, 2019 · 3 comments

Comments

@su-chang
Copy link

In FlashStore, set value to the same key more than one time will make the size wrong, but no Error.

If we set the same key more than one time

await flashStore.set('name', '1')
await flashStore.set('name', '2')
await flashStore.set('name', '3')
const size = await flashStore.size // size: 3

and then let's restart the script again, size: 4.

If execute this script only

const size = await flashStore.size // size: 1, right!

I'm confused with this case.

BTW, Im trying to find out the reason about Issue: wechaty/wechaty-puppet-padpro#191

@huan
Copy link
Owner

huan commented Oct 19, 2019

Thanks for the reporting.

Could you please help me to add an unit test, which can reproduce your case, and make the test fail?

Thank you very much.

@huan
Copy link
Owner

huan commented Jan 29, 2020

@su-chang Thanks for the unit test, and that's a great catch!

We are now tracking this issue at only-cliches/snap-db#12

huan added a commit that referenced this issue Jan 30, 2020
@huan
Copy link
Owner

huan commented Feb 7, 2020

Fixed by #69

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants