Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add subselect builder for insert #133

Merged
merged 2 commits into from
Nov 20, 2023
Merged

add subselect builder for insert #133

merged 2 commits into from
Nov 20, 2023

Conversation

cemremengu
Copy link
Contributor

closes #132

huandu
huandu requested changes Nov 18, 2023
View reviewed changes
insert.go Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Nov 18, 2023 •
edited

Coverage Status

coverage: 96.32% (+0.02%) from 96.304%
when pulling 9c1c183 on cemremengu:insertselect
into fd93ff9 on huandu:master.

huandu
huandu approved these changes Nov 20, 2023
View reviewed changes
Copy link
Owner

@huandu huandu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@huandu huandu merged commit eb77f78 into huandu:master Nov 20, 2023
2 checks passed
@cemremengu cemremengu deleted the insertselect branch November 20, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huandu huandu huandu approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Insert with subselect
3 participants
@cemremengu @coveralls @huandu