Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put the backwards compatibility code #11

Closed
wants to merge 1 commit into from

Conversation

xiekeyi98
Copy link

Because #10
It will be broken when running rather than compiled.
I think it will be dangerous if someone did not know this.

This break may be occurred because golang uses the register to pass the param after go1.17, and some magic about go stack will be broken.

This PR try to abandon some one use this library after go1.17

image

@xiekeyi98
Copy link
Author

The ci has broken at the latest it expected.

@huandu
Copy link
Owner

huandu commented Nov 16, 2021

Thanks for your PR.

I was trying to fix #10 but failed. I haven't found a valid solution right now. However, I still want to fix it some day. I'm reading Go runtime code more thoroughly to find other possible ways to hack it.

To make go1.17 users more clear about the status of this package, I can update README soon to highlight the issue.

@xiekeyi98
Copy link
Author

Thanks for your PR.

I was trying to fix #10 but failed. I haven't found a valid solution right now. However, I still want to fix it some day. I'm reading Go runtime code more thoroughly to find other possible ways to hack it.

To make go1.17 users more clear about the status of this package, I can update README soon to highlight the issue.

I would be amazed if this problem can be fixed.

I think it is the difficult problem, thank you for trying to fix this.

@xiekeyi98 xiekeyi98 closed this Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants