Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade gym to 0.23.1 #18

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,10 @@ pip install -e .
### Coding example
```python
import gym
import gym_go

go_env = gym.make('gym_go:go-v0', size=7, komi=0, reward_method='real')
go_env = gym.make('go-v0', size=7, komi=0, reward_method='real')
go_env.reset()

first_action = (2,5)
second_action = (5,2)
Expand Down
4 changes: 3 additions & 1 deletion demo.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import argparse

import gym
import gym_go

# Arguments
parser = argparse.ArgumentParser(description='Demo Go Environment')
Expand All @@ -9,7 +10,8 @@
args = parser.parse_args()

# Initialize environment
go_env = gym.make('gym_go:go-v0', size=args.boardsize, komi=args.komi)
go_env = gym.make('go-v0', size=args.boardsize, komi=args.komi)
go_env.reset()

# Game loop
done = False
Expand Down
3 changes: 2 additions & 1 deletion gym_go/tests/efficiency.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
import unittest

import gym
import gym_go
import numpy as np
from tqdm import tqdm

Expand All @@ -11,7 +12,7 @@ class Efficiency(unittest.TestCase):
iterations = 64

def setUp(self) -> None:
self.env = gym.make('gym_go:go-v0', size=self.boardsize, reward_method='real')
self.env = gym.make('go-v0', size=self.boardsize, reward_method='real')

def testOrderedTrajs(self):
durs = []
Expand Down
17 changes: 10 additions & 7 deletions gym_go/tests/test_basics.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,13 @@ class TestGoEnvBasics(unittest.TestCase):

def __init__(self, *args, **kwargs):
super().__init__(*args, **kwargs)
self.env = gym.make('gym_go:go-v0', size=7, reward_method='real')
self.env = gym.make('go-v0', size=7, reward_method='real')

def setUp(self):
self.env.reset()

def test_state(self):
env = gym.make('gym_go:go-v0', size=7)
env = gym.make('go-v0', size=7)
state = env.reset()
self.assertIsInstance(state, np.ndarray)
self.assertEqual(state.shape[0], govars.NUM_CHNLS)
Expand All @@ -27,7 +27,7 @@ def test_board_sizes(self):
expected_sizes = [7, 13, 19]

for expec_size in expected_sizes:
env = gym.make('gym_go:go-v0', size=expec_size)
env = gym.make('go-v0', size=expec_size)
state = env.reset()
self.assertEqual(state.shape[1], expec_size)
self.assertEqual(state.shape[2], expec_size)
Expand Down Expand Up @@ -150,7 +150,7 @@ def test_game_does_not_end_with_disjoint_passes(self):
self.assertFalse(done)

def test_num_liberties(self):
env = gym.make('gym_go:go-v0', size=7)
env = gym.make('go-v0', size=7)

steps = [(0, 0), (0, 1)]
libs = [(2, 0), (1, 2)]
Expand All @@ -173,7 +173,8 @@ def test_num_liberties(self):
self.assertEqual(whitelibs, libs[1], state)

def test_komi(self):
env = gym.make('gym_go:go-v0', size=7, komi=2.5, reward_method='real')
env = gym.make('go-v0', size=7, komi=2.5, reward_method='real')
env.reset()

# White win
_ = env.step(None)
Expand Down Expand Up @@ -223,7 +224,8 @@ def test_children(self):
self.assertTrue((children[a] == 0).all())

def test_real_reward(self):
env = gym.make('gym_go:go-v0', size=7, reward_method='real')
env = gym.make('go-v0', size=7, reward_method='real')
env.reset()

# In game
state, reward, done, info = env.step((0, 0))
Expand Down Expand Up @@ -258,7 +260,8 @@ def test_real_reward(self):
env.close()

def test_heuristic_reward(self):
env = gym.make('gym_go:go-v0', size=7, reward_method='heuristic')
env = gym.make('go-v0', size=7, reward_method='heuristic')
env.reset()

# In game
state, reward, done, info = env.step((0, 0))
Expand Down
8 changes: 5 additions & 3 deletions gym_go/tests/test_invalid_moves.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ class TestGoEnvInvalidMoves(unittest.TestCase):

def __init__(self, *args, **kwargs):
super().__init__(*args, **kwargs)
self.env = gym.make('gym_go:go-v0', size=7, reward_method='real')
self.env = gym.make('go-v0', size=7, reward_method='real')

def setUp(self):
self.env.reset()
Expand Down Expand Up @@ -185,7 +185,8 @@ def test_small_suicide(self):
:return:
"""

self.env = gym.make('gym_go:go-v0', size=3, reward_method='real')
self.env = gym.make('go-v0', size=3, reward_method='real')
self.env.reset()
for move in [6, 7, 8, 5, 4, 8, 0, 1]:
state, reward, done, info = self.env.step(move)

Expand All @@ -202,7 +203,8 @@ def test_invalid_after_capture(self):
:return:
"""

self.env = gym.make('gym_go:go-v0', size=3, reward_method='real')
self.env = gym.make('go-v0', size=3, reward_method='real')
self.env.reset()
for move in [0, 8, 6, 4, 1, 2, 3, 7]:
state, reward, done, info = self.env.step(move)

Expand Down
2 changes: 1 addition & 1 deletion gym_go/tests/test_valid_moves.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ class TestGoEnvValidMoves(unittest.TestCase):

def __init__(self, *args, **kwargs):
super().__init__(*args, **kwargs)
self.env = gym.make('gym_go:go-v0', size=7, reward_method='real')
self.env = gym.make('go-v0', size=7, reward_method='real')

def setUp(self):
self.env.reset()
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@
setup(
name='gym_go',
version='0.0.1',
install_requires=['gym'] # and other dependencies
install_requires=['gym==0.23.1'] # and other dependencies
)