Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix depth buffering for camera-based observations #14

Merged
merged 7 commits into from
Oct 16, 2020

Conversation

JVillella
Copy link
Contributor

@JVillella JVillella commented Oct 15, 2020

Fix,

# XXX: Though we don't need the depth buffer returned, setting this to 0
#      causes undefined behaviour where the ordering of meshes is random.
fb_props.setDepthBits(1)

Previously sometimes the vehicles would be underneath the map causing the smarts/core/test_observations to fail.


I also pinned RLlib which was defaulting to install 1.0 which our examples don't presently support.


Added instructions for running Envision in Docker.

@JVillella JVillella requested review from Gamenot and aurorahcx and removed request for Gamenot October 15, 2020 23:28
@Gamenot
Copy link
Collaborator

Gamenot commented Oct 15, 2020

If observations fail again the same way we should update the buffer to 8 bit.

smarts/core/vehicle.py Outdated Show resolved Hide resolved
@davidrusu davidrusu merged commit 8278850 into master Oct 16, 2020
@liamchzh liamchzh mentioned this pull request Oct 20, 2020
@JVillella JVillella deleted the fix-depth-buffer-for-obs branch November 24, 2020 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants