[#1191] add weightedResponseTime loadbalancer #1204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liubao68
reviewed
Jan 25, 2024
| import org.springframework.cloud.client.ServiceInstance; | ||
|
|
||
| public class ServiceInstanceMetrics { | ||
| private final static Map<String, ServerMetrics> INSTANCE_SERVER_METRICS_MAP = new ConcurrentHashMap<>(); |
There was a problem hiding this comment.
Use cache map with key expiration to avoid memory leak
liubao68
reviewed
Jan 25, 2024
| @@ -80,6 +84,8 @@ protected <T> T doExecute(URI url, @Nullable String uriTemplate, @Nullable HttpM | |||
| Assert.notNull(url, "URI is required"); | |||
| Assert.notNull(method, "HttpMethod is required"); | |||
| ClientHttpResponse response = null; | |||
| InvocationContext context = InvocationContextHolder.getOrCreateInvocationContext(); | |||
There was a problem hiding this comment.
add gateway record
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1204 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 123 123
Lines 2319 2318 -1
Branches 201 201
======================================
+ Misses 2319 2318 -1 ☔ View full report in Codecov by Sentry. |
chengyouling
added a commit
that referenced
this pull request
Feb 18, 2024
chengyouling
added a commit
that referenced
this pull request
Feb 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.