Add CCE service #19
Merged
Add CCE service #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # CHANGELOG.md
|
I wonder the relationship between this parties and Kubernetes parties, can they work together? |
niuzhenguo
reviewed
Aug 7, 2018
CHANGELOG.md
Outdated
| @@ -1,7 +1,15 @@ | |||
| ## 1.1.1 (Unreleased) | |||
| ## 1.1.2 (Unreleased) | |||
There was a problem hiding this comment.
why adding a new release stanza 1.1.2? You should not manually changed the v1.1.1 below to released which should be triggered by hashicorp release bot.
huaweicloud/provider_test.go
Outdated
| func testAccPreCheckCCENode(t *testing.T) { | ||
| testAccPreCheckRequiredEnvVars(t) | ||
| if OS_SSH_KEY == "" { | ||
| t.Fatal("OS_SSH_KEY must be set for acceptance tests") |
There was a problem hiding this comment.
better to also use t.Skip here as above for such new added ENV variables in case it breaks all tests.
ghost
added
the
niuzhenguo
reviewed
Nov 16, 2018
| vpc_id = "%s" | ||
| subnet_id = "%s" | ||
| container_network_type = "overlay_l2" | ||
| }`, OS_VPC_ID, OS_SUBNET_ID) |
There was a problem hiding this comment.
all such OS_SUBNET_ID should be changed to OS_NETWORK_ID which we already added.
niuzhenguo
reviewed
Nov 16, 2018
| var node nodes.Nodes | ||
|
|
||
| resource.Test(t, resource.TestCase{ | ||
| PreCheck: func() { testAccPreCheck(t) }, |
There was a problem hiding this comment.
s/testAccPreCheck/testAccPreCheckCCENode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a capability to manage Huaweicloud CCE service.