add data_source_huaweicloud_gaussdb_mysql_instances #855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jason-Zhang9309
force-pushed
the
dev-gaussdb
branch
from
47cce1b
to
4eeb5b8
Compare
ShiChangkuo
reviewed
Jan 25, 2021
| } | ||
| } | ||
|
|
||
| func testAccCheckGaussdbMysqlInstancesDataLen(n string) resource.TestCheckFunc { |
There was a problem hiding this comment.
seems this function is never called.
BTW, this check funcction is not recommended, you can try resource.TestCheckResourceAttr("data.huaweicloud_gaussdb_mysql_instances.test", "instances.#", "1"),
There was a problem hiding this comment.
new test result:
make testacc TEST='./huaweicloud' TESTARGS='-run TestAccGaussdbMysqlInstancesDataSource_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud -v -run TestAccGaussdbMysqlInstancesDataSource_basic -timeout 360m -parallel 4
=== RUN TestAccGaussdbMysqlInstancesDataSource_basic
=== PAUSE TestAccGaussdbMysqlInstancesDataSource_basic
=== CONT TestAccGaussdbMysqlInstancesDataSource_basic
--- PASS: TestAccGaussdbMysqlInstancesDataSource_basic (813.94s)
PASS
ok github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud 813.983s
Jason-Zhang9309
force-pushed
the
dev-gaussdb
branch
from
4eeb5b8
to
1746d34
Compare
Jason-Zhang9309
force-pushed
the
dev-gaussdb
branch
from
1746d34
to
3aec355
Compare
|
use getting detail only in necessary parts, make the code logic clearer new test result: make testacc TEST='./huaweicloud' TESTARGS='-run TestAccGaussdbMysqlInstancesDataSource_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud -v -run TestAccGaussdbMysqlInstancesDataSource_basic -timeout 360m -parallel 4
=== RUN TestAccGaussdbMysqlInstancesDataSource_basic
=== PAUSE TestAccGaussdbMysqlInstancesDataSource_basic
=== CONT TestAccGaussdbMysqlInstancesDataSource_basic
--- PASS: TestAccGaussdbMysqlInstancesDataSource_basic (797.28s)
PASS
ok github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud 797.328s |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #853
Test result: