Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: vpcep approval can work cross-project #1010

Merged
merged 1 commit into from
Mar 31, 2021
Merged

fix: vpcep approval can work cross-project #1010

merged 1 commit into from
Mar 31, 2021

Conversation

Lance52259
Copy link
Collaborator

What this PR does / why we need it:
-huaweicloud_vpcep_approval cannot be working cross-project when endpoint and vpcep service are in different projects or account.
When provider use get function of vpcep endpoint in state refresh, wrong project id or wrong user info will be using to get endpoint.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

NONE

Special notes for your reviewer:

Release note:

1. Using `ListConnections` to instead of `Get` to repair the problem.

PR Checklist

  • Tests added/passed.
  • Documentation updated.
  • Schema updated.

Acceptance Steps Performed

NONE

@niuzhenguo niuzhenguo added this to To do in kanban Mar 30, 2021
@niuzhenguo niuzhenguo moved this from To do to In progress in kanban Mar 30, 2021
@Lance52259 Lance52259 self-assigned this Mar 31, 2021
@ShiChangkuo ShiChangkuo merged commit 8d5dbb8 into huaweicloud:master Mar 31, 2021
kanban automation moved this from In progress to Done Mar 31, 2021
@Lance52259 Lance52259 deleted the br_vpcep_approval_active branch April 2, 2021 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants