New vpc channel resource support #1273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lance52259
changed the title
ShiChangkuo
reviewed
Jul 12, 2021
Comment on lines
209
to
212
| ecsClient, err := config.ComputeV1Client(config.GetRegion(d)) | ||
| if err != nil { | ||
| return result, fmtp.Errorf("Error creating HuaweiCloud ECS v1 client: %s", err) | ||
| } |
There was a problem hiding this comment.
suggest to put those outside of the for loop.
|
|
||
| members { | ||
| id = huaweicloud_compute_instance.test.id | ||
| weight = 30 |
docs/resources/apig_vpc_channel.md
Outdated
|
|
||
| The following arguments are supported: | ||
|
|
||
| * `region` - (Optional, String, ForceNew) Specifies the region in which to create the APIG application resource. |
There was a problem hiding this comment.
the description is wrong
There was a problem hiding this comment.
This description has been updated
| } | ||
| } | ||
|
|
||
| resource "huaweicloud_compute_eip_associate" "test" { |
There was a problem hiding this comment.
is it necessary to associate the eip to an ecs instance?
There was a problem hiding this comment.
thx, this is unnecessary and has been removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The API web backend and policy need vpc channel configuration.
Which issue this PR fixes:
reference #1249
Special notes for your reviewer:
Release note:
PR Checklist
Acceptance Steps Performed
test for ECS member type
test for EIP member type