Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature dli new #1321

Merged
merged 6 commits into from
Jul 31, 2021
Merged

Feature dli new #1321

merged 6 commits into from
Jul 31, 2021

Conversation

hmbig2
Copy link
Collaborator

@hmbig2 hmbig2 commented Jul 29, 2021

What this PR does / why we need it:
Upgrade DLI queues to the go SDK of huaweicloud services
Which issue this PR fixes:
fixes #1256

Special notes for your reviewer:

Release note:


PR Checklist

  • Tests added/passed.
  • Documentation updated.
  • Schema updated.

Acceptance Steps Performed

make testacc TEST='./huaweicloud' TESTARGS='-run=TestAccDliQueueV1_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud -v -run=TestAccDliQueueV1_basic -timeout 360m -parallel 4
=== RUN   TestAccDliQueueV1_basic
=== PAUSE TestAccDliQueueV1_basic
=== CONT  TestAccDliQueueV1_basic
--- PASS: TestAccDliQueueV1_basic (18.61s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud       19.318s

Copy link
Collaborator

@chengxiangdong chengxiangdong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all commits has resolved
CC @ShiChangkuo

Copy link
Collaborator

@ShiChangkuo ShiChangkuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hmbig2 please remove the files in huaweicloud dir if you want to make a new pakage for DLI.

BTW, it's not recommended to use file names and function names with version numbers(_v1)

docs/resources/dli_queue.md Show resolved Hide resolved
docs/resources/dli_queue.md Outdated Show resolved Hide resolved
docs/resources/dli_queue.md Outdated Show resolved Hide resolved
docs/resources/dli_queue.md Outdated Show resolved Hide resolved
@ShiChangkuo ShiChangkuo merged commit 4b97d9e into huaweicloud:master Jul 31, 2021
@hmbig2 hmbig2 deleted the feature_dli_new branch August 5, 2021 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade DLI queues to the go SDK of huaweicloud services
3 participants