Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't use d.Set("id") #155

Merged
merged 1 commit into from
Jul 8, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion huaweicloud/resource_huaweicloud_cce_cluster_v3.go
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,6 @@ func resourceCCEClusterV3Read(d *schema.ResourceData, meta interface{}) error {
return fmt.Errorf("Error retrieving HuaweiCloud CCE: %s", err)
}

d.Set("id", n.Metadata.Id)
d.Set("name", n.Metadata.Name)
d.Set("status", n.Status.Phase)
d.Set("flavor_id", n.Spec.Flavor)
Expand Down
6 changes: 0 additions & 6 deletions huaweicloud/resource_huaweicloud_dws_cluster.go
Original file line number Diff line number Diff line change
Expand Up @@ -441,12 +441,6 @@ func resourceDwsClusterRead(d *schema.ResourceData, meta interface{}) error {
}
}

if v, ok := res["id"]; ok {
if err := d.Set("id", v); err != nil {
return fmt.Errorf("Error reading Cluster:id, err: %s", err)
}
}

if v, ok := res["port"]; ok {
if err := d.Set("port", v); err != nil {
return fmt.Errorf("Error reading Cluster:port, err: %s", err)
Expand Down
6 changes: 0 additions & 6 deletions huaweicloud/resource_huaweicloud_mls_instance.go
Original file line number Diff line number Diff line change
Expand Up @@ -354,12 +354,6 @@ func resourceMlsInstanceRead(d *schema.ResourceData, meta interface{}) error {
}
}

if v, ok := res["id"]; ok {
if err := d.Set("id", v); err != nil {
return fmt.Errorf("Error reading Instance:id, err: %s", err)
}
}

if v, ok := res["innerEndPoint"]; ok {
if err := d.Set("inner_endpoint", v); err != nil {
return fmt.Errorf("Error reading Instance:inner_endpoint, err: %s", err)
Expand Down
1 change: 0 additions & 1 deletion huaweicloud/resource_huaweicloud_rts_software_config_v1.go
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,6 @@ func resourceSoftwareConfigV1Read(d *schema.ResourceData, meta interface{}) erro
return fmt.Errorf("Error retrieving HuaweiCloud Vpc: %s", err)
}

d.Set("id", n.Id)
d.Set("name", n.Name)
d.Set("config", n.Config)
d.Set("group", n.Group)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,6 @@ func resourceVpcPeeringAccepterRead(d *schema.ResourceData, meta interface{}) er
return fmt.Errorf("Error retrieving Huaweicloud Vpc Peering Connection: %s", err)
}

d.Set("id", n.ID)
d.Set("name", n.Name)
d.Set("status", n.Status)
d.Set("vpc_id", n.RequestVpcInfo.VpcId)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,6 @@ func resourceVPCPeeringV2Read(d *schema.ResourceData, meta interface{}) error {
return fmt.Errorf("Error retrieving Huaweicloud Vpc Peering Connection: %s", err)
}

d.Set("id", n.ID)
d.Set("name", n.Name)
d.Set("status", n.Status)
d.Set("vpc_id", n.RequestVpcInfo.VpcId)
Expand Down
1 change: 0 additions & 1 deletion huaweicloud/resource_huaweicloud_vpc_route_v2.go
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,6 @@ func resourceVpcRouteV2Read(d *schema.ResourceData, meta interface{}) error {
d.Set("destination", n.Destination)
d.Set("tenant_id", n.Tenant_Id)
d.Set("vpc_id", n.VPC_ID)
d.Set("id", n.RouteID)
d.Set("region", GetRegion(d, config))

return nil
Expand Down
1 change: 0 additions & 1 deletion huaweicloud/resource_huaweicloud_vpc_v1.go
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,6 @@ func resourceVirtualPrivateCloudV1Read(d *schema.ResourceData, meta interface{})
return fmt.Errorf("Error retrieving Huaweicloud Vpc: %s", err)
}

d.Set("id", n.ID)
d.Set("name", n.Name)
d.Set("cidr", n.CIDR)
d.Set("status", n.Status)
Expand Down