Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(WAF): waf reference table support epsID #2965

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

deer-hang
Copy link
Contributor

What this PR does / why we need it:

  • waf reference support epsid
    Which issue this PR fixes:
    (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
    fixes #xxx

Special notes for your reviewer:

Release note:


PR Checklist

  • Tests added/passed.
  • Documentation updated.
  • Schema updated.

Acceptance Steps Performed

make testacc TEST='./huaweicloud/services/acceptance/waf' TESTARGS='-run TestAccWafReferenceTableV1_'

==> Checking that code complies with gofmt requirements... 
TF_ACC=1 go test ./huaweicloud/services/acceptance/waf -v -run TestAccWafReferenceTableV1_ -timeout 360m -parallel 4 
=== RUN   TestAccWafReferenceTableV1_basic 
=== PAUSE TestAccWafReferenceTableV1_basic 
=== RUN   TestAccWafReferenceTableV1_withEpsID
=== PAUSE TestAccWafReferenceTableV1_withEpsID
=== CONT  TestAccWafReferenceTableV1_basic
=== CONT  TestAccWafReferenceTableV1_withEpsID 
--- PASS: TestAccWafReferenceTableV1_basic (361.38s) 
--- PASS: TestAccWafReferenceTableV1_withEpsID (369.74s) 
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/waf       370.030s
make testacc TEST='./huaweicloud/services/acceptance/waf' TESTARGS='-run TestAccDataSourceReferenceTablesV1_'

==> Checking that code complies with gofmt requirements... 
TF_ACC=1 go test ./huaweicloud/services/acceptance/waf -v -run TestAccDataSourceReferenceTablesV1_ -timeout 360m -parallel 4 
=== RUN   TestAccDataSourceReferenceTablesV1_basic 
--- PASS: TestAccDataSourceReferenceTablesV1_basic (357.52s) 
=== RUN   TestAccDataSourceReferenceTablesV1_withEpsID
--- PASS: TestAccDataSourceReferenceTablesV1_withEpsID (364.06s) 
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/waf       721.721s

@houpeng80
Copy link
Collaborator

/lgtm

@github-actions github-actions bot added the LGTM /lgtm label Apr 28, 2023
@github-actions github-actions bot removed the LGTM /lgtm label Apr 28, 2023
@Jason-Zhang9309
Copy link
Collaborator

/lgtm

@github-actions github-actions bot added the LGTM /lgtm label Apr 28, 2023
@ShiChangkuo ShiChangkuo merged commit 0bd8aad into huaweicloud:master Apr 28, 2023
9 checks passed
@deer-hang deer-hang deleted the fix-waf-reference-epsid branch May 6, 2023 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants