support extend_param in cce node, add two new param fixed_ip and hw_passthrough #947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jason-Zhang9309
force-pushed
the
dev-cce-node-extendParam
branch
from
5c7d17e
to
35c8802
Compare
ShiChangkuo
reviewed
Feb 27, 2021
| extendParam[key] = val.(string) | ||
| } | ||
| if v, ok := extendParam["periodNum"]; ok { | ||
| periodNum, err := strconv.Atoi(v.(string)) |
There was a problem hiding this comment.
the type of value is already stirng, so no need to convert it again.
Jason-Zhang9309
force-pushed
the
dev-cce-node-extendParam
branch
5 times, most recently
from
805fa0a
to
29c588b
Compare
Jason-Zhang9309
force-pushed
the
dev-cce-node-extendParam
branch
from
29c588b
to
d52b609
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
support extend_param in cce node
add two new param fixed_ip and hw_passthrough
Which issue this PR fixes:
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)fixes #xxx
Special notes for your reviewer:
Release note:
PR Checklist
Acceptance Steps Performed