Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change param sharding_num and coordinator_num to required in opengauss #959

Merged
merged 1 commit into from
Mar 4, 2021

Conversation

Jason-Zhang9309
Copy link
Collaborator

What this PR does / why we need it:

change param sharding_num and coordinator_num to required in opengauss

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:


PR Checklist

  • Tests added/passed.
  • Documentation updated.
  • Schema updated.

Acceptance Steps Performed

make testacc TEST='./huaweicloud' TESTARGS='-run=TestAccSomethingV0_basic'
...
=== RUN   TestAccSomethingV0_basic
--- PASS: TestAccSomethingV0_basic (70.75s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud       70.796s

@ShiChangkuo
Copy link
Collaborator

@Jason-Zhang9309 we can keep them as optional and set them default to 3.

@Jason-Zhang9309
Copy link
Collaborator Author

@Jason-Zhang9309 we can keep them as optional and set them default to 3.

Sure, use default is a better choice

@ShiChangkuo ShiChangkuo merged commit 908e431 into huaweicloud:master Mar 4, 2021
@Jason-Zhang9309 Jason-Zhang9309 deleted the dev-opengauss branch March 15, 2021 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants