Decompose

src/main/java/org/kohsuke/github/GitHubClient.java

@@ -638,9 +638,7 @@ private void detectInvalidCached404Response(GitHubConnectorResponse connectorRes
         // scenarios. If GitHub ever fixes their issue and/or begins providing accurate ETags to
         // their 404 responses, this will result in at worst two requests being made for each 404
         // responses. However, only the second request will count against rate limit.
-        if (connectorResponse.statusCode() == 404 && Objects.equals(connectorResponse.request().method(), "GET")
-                && connectorResponse.header("ETag") != null
-                && !Objects.equals(connectorResponse.request().header("Cache-Control"), "no-cache")) {
+        if (isCacheableResourceNotFound(connectorResponse)) {
             LOGGER.log(FINE,
                     "Encountered GitHub invalid cached 404 from " + connectorResponse.request().url()
                             + ". Retrying with \"Cache-Control\"=\"no-cache\"...");
@@ -652,6 +650,12 @@ private void detectInvalidCached404Response(GitHubConnectorResponse connectorRes
         }
     }
 
+    private boolean isCacheableResourceNotFound(GitHubConnectorResponse connectorResponse){
+        return connectorResponse.statusCode() == 404 && Objects.equals(connectorResponse.request().method(), "GET")
+                && connectorResponse.header("ETag") != null
+                && !Objects.equals(connectorResponse.request().header("Cache-Control"), "no-cache");
+    }
+
     private void noteRateLimit(@Nonnull RateLimitTarget rateLimitTarget,
             @Nonnull GitHubConnectorResponse connectorResponse) {
         try {