Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate limit handlers using HttpURLConnection #1298

Merged
merged 2 commits into from
Nov 17, 2021

Conversation

bitwiseman
Copy link
Member

Description

This change completes the deprecation of all classes and methods that use HttpURLConnection.

Before submitting a PR:

We love getting PRs, but we hate asking people for the same basic changes every time.

  • Push your changes to a branch other than main. Create your PR from that branch.
  • Add JavaDocs and other comments
  • Write tests that run and pass in CI. See CONTRIBUTING.md for details on how to capture snapshot data.
  • Run mvn -D enable-ci clean install site locally. If this command doesn't succeed, your change will not pass CI.

When creating a PR:

  • Fill in the "Description" above.
  • Enable "Allow edits from maintainers".

@codecov
Copy link

codecov bot commented Nov 16, 2021

Codecov Report

Merging #1298 (8effe61) into main (1535817) will increase coverage by 0.01%.
The diff coverage is 88.77%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1298      +/-   ##
============================================
+ Coverage     77.88%   77.89%   +0.01%     
- Complexity     1998     2011      +13     
============================================
  Files           194      197       +3     
  Lines          6209     6217       +8     
  Branches        361      358       -3     
============================================
+ Hits           4836     4843       +7     
- Misses         1159     1160       +1     
  Partials        214      214              
Impacted Files Coverage Δ
src/main/java/org/kohsuke/github/GitHub.java 81.44% <ø> (ø)
...e/github/extras/okhttp3/OkHttpGitHubConnector.java 84.90% <ø> (+1.08%) ⬆️
...tHubConnectorResponseHttpUrlConnectionAdapter.java 87.69% <37.50%> (-7.14%) ⬇️
...c/main/java/org/kohsuke/github/GitHubResponse.java 90.69% <66.66%> (-4.31%) ⬇️
src/main/java/org/kohsuke/github/GitHubClient.java 90.36% <91.66%> (+0.02%) ⬆️
...ain/java/org/kohsuke/github/AbuseLimitHandler.java 78.94% <100.00%> (+3.94%) ⬆️
...va/org/kohsuke/github/GitHubAbuseLimitHandler.java 100.00% <100.00%> (ø)
...rc/main/java/org/kohsuke/github/GitHubBuilder.java 92.04% <100.00%> (+0.18%) ⬆️
...ke/github/GitHubConnectorResponseErrorHandler.java 100.00% <100.00%> (ø)
...ava/org/kohsuke/github/GitHubRateLimitHandler.java 100.00% <100.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1535817...8effe61. Read the comment docs.

@bitwiseman bitwiseman force-pushed the task/deprecation2 branch 3 times, most recently from 27b5470 to 85b403a Compare November 16, 2021 23:37
@bitwiseman bitwiseman merged commit 50d4ae6 into hub4j:main Nov 17, 2021
@bitwiseman bitwiseman deleted the task/deprecation2 branch November 17, 2021 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant