Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HttpClientGitHubConnector and multirelease jar implementation #1300

Merged
merged 7 commits into from
Nov 19, 2021

Conversation

bitwiseman
Copy link
Member

@bitwiseman bitwiseman commented Nov 19, 2021

Description

This change converts the production jar file to a multirelease jar file and adds a HttpClientGitHubConnector class to address reflection issues in Java 11+.

Before submitting a PR:

We love getting PRs, but we hate asking people for the same basic changes every time.

  • Push your changes to a branch other than main. Create your PR from that branch.
  • Add JavaDocs and other comments
  • Write tests that run and pass in CI. See CONTRIBUTING.md for details on how to capture snapshot data.
  • Run mvn -D enable-ci clean install site locally. If this command doesn't succeed, your change will not pass CI.

When creating a PR:

  • Fill in the "Description" above.
  • Enable "Allow edits from maintainers".

@bitwiseman bitwiseman force-pushed the task/multirelease branch 5 times, most recently from 16c44a7 to e3003e5 Compare November 19, 2021 03:35
@codecov
Copy link

codecov bot commented Nov 19, 2021

Codecov Report

Merging #1300 (5699e58) into main (aad8b9a) will increase coverage by 0.02%.
The diff coverage is 80.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1300      +/-   ##
============================================
+ Coverage     77.86%   77.89%   +0.02%     
- Complexity     2011     2012       +1     
============================================
  Files           197      197              
  Lines          6220     6219       -1     
  Branches        362      359       -3     
============================================
+ Hits           4843     4844       +1     
- Misses         1160     1161       +1     
+ Partials        217      214       -3     
Impacted Files Coverage Δ
...e/github/extras/okhttp3/OkHttpGitHubConnector.java 84.61% <ø> (-0.30%) ⬇️
...ohsuke/github/internal/DefaultGitHubConnector.java 92.30% <80.00%> (-7.70%) ⬇️
src/main/java/org/kohsuke/github/GHRepository.java 68.42% <0.00%> (ø)
...ava/org/kohsuke/github/GitHubRateLimitChecker.java 75.00% <0.00%> (+5.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aad8b9a...5699e58. Read the comment docs.

@bitwiseman bitwiseman merged commit d46bca7 into hub4j:main Nov 19, 2021
@bitwiseman bitwiseman deleted the task/multirelease branch November 19, 2021 16:51
@nedtwigg
Copy link

Do you plan to cut a new release soon? Or are you planning to tackle every breaking change issue before shipping a new release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants