Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue #1343 - Updated POM File to amend manifest #1346

Merged
merged 1 commit into from
Dec 21, 2021
Merged

Fix Issue #1343 - Updated POM File to amend manifest #1346

merged 1 commit into from
Dec 21, 2021

Conversation

EasyG0ing1
Copy link
Contributor

@EasyG0ing1 EasyG0ing1 commented Dec 19, 2021

added

Automatic-Module-Name: org.kohsuke.github.api

to manifest file for compliance with modular naming requirements.

Fixes #1343

Automatic-Module-Name: org.kohsuke.github.api

to manifest file for compliance with modular naming requirements
@EasyG0ing1 EasyG0ing1 changed the title Added Updated POM File to amend manifest Dec 19, 2021
@EasyG0ing1 EasyG0ing1 changed the title Updated POM File to amend manifest Fixes Issue #1343 - Updated POM File to amend manifest Dec 20, 2021
@EasyG0ing1 EasyG0ing1 changed the title Fixes Issue #1343 - Updated POM File to amend manifest Fix Issue #1343 - Updated POM File to amend manifest Dec 20, 2021
@codecov
Copy link

codecov bot commented Dec 21, 2021

Codecov Report

Merging #1346 (bcd62e0) into main (06b0312) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1346   +/-   ##
=========================================
  Coverage     78.18%   78.18%           
  Complexity     2045     2045           
=========================================
  Files           200      200           
  Lines          6284     6284           
  Branches        356      356           
=========================================
  Hits           4913     4913           
  Misses         1162     1162           
  Partials        209      209           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06b0312...bcd62e0. Read the comment docs.

@bitwiseman bitwiseman merged commit 4ac5977 into hub4j:main Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potential problem from lack of modular declaration for github-api jar file
2 participants