Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore org.kohsuke.github.internal for API stability #1421

Merged
merged 2 commits into from
Apr 7, 2022

Conversation

bitwiseman
Copy link
Member

Description

Before submitting a PR:

  • Changes must not break binary backwards compatibility. If you are unclear on how to make the change you think is needed while maintaining backward compatibility, CONTRIBUTING.md for details.
  • Add JavaDocs and other comments as appropriate. Consider including links in comments to relevant documentation on https://docs.github.com/en/rest .
  • Add tests that cover any added or changed code. This generally requires capturing snapshot test data. See CONTRIBUTING.md for details.
  • Run mvn -D enable-ci clean install site locally. If this command doesn't succeed, your change will not pass CI.
  • Push your changes to a branch other than main. You will create your PR from that branch.

When creating a PR:

  • Fill in the "Description" above with clear summary of the changes. This includes:
    • If this PR fixes one or more issues, include "Fixes #" lines for each issue.
    • Provide links to relevant documentation on https://docs.github.com/en/rest where possible.
  • All lines of new code should be covered by tests as reported by code coverage. Any lines that are not covered must have PR comments explaining why they cannot be covered. For example, "Reaching this particular exception is hard and is not a particular common scenario."
  • Enable "Allow edits from maintainers".

@codecov
Copy link

codecov bot commented Apr 7, 2022

Codecov Report

Merging #1421 (5cd52d7) into main (9e440f5) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #1421   +/-   ##
=========================================
  Coverage     78.22%   78.22%           
  Complexity     2073     2073           
=========================================
  Files           201      201           
  Lines          6341     6341           
  Branches        357      357           
=========================================
  Hits           4960     4960           
  Misses         1172     1172           
  Partials        209      209           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e440f5...5cd52d7. Read the comment docs.

Comment on lines +408 to +409
<!-- TODO: started failing in CI recently. This is part of the multi-release structure. -->
<exclude>org.kohsuke.github.extras.HttpClientGitHubConnector#HttpClientGitHubConnector(java.net.http.HttpClient)</exclude>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is unclear why this is happening. It doesn't happen on my local build.

@bitwiseman bitwiseman merged commit 06f2f8b into main Apr 7, 2022
@bitwiseman bitwiseman deleted the bitwiseman-patch-1 branch April 7, 2022 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant