Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing porperties to the #1447

merged 7 commits into from Jun 20, 2022


Copy link

@yusuf-erdem yusuf-erdem commented Apr 28, 2022


I need to find Workflow Job's running machine type (ubuntu, windows, macos). Github Api has labels property which includes that information. This PR adds labels information to the GHWorkflowJob

Fixes #1445

Before submitting a PR:

  • Changes must not break binary backwards compatibility. If you are unclear on how to make the change you think is needed while maintaining backward compatibility, for details.
  • Add JavaDocs and other comments as appropriate. Consider including links in comments to relevant documentation on .
  • Add tests that cover any added or changed code. This generally requires capturing snapshot test data. See for details.
  • Run mvn -D enable-ci clean install site locally. If this command doesn't succeed, your change will not pass CI.
  • Push your changes to a branch other than main. You will create your PR from that branch.

When creating a PR:

  • Fill in the "Description" above with clear summary of the changes. This includes:
    • If this PR fixes one or more issues, include "Fixes #" lines for each issue.
    • Provide links to relevant documentation on where possible.
  • All lines of new code should be covered by tests as reported by code coverage. Any lines that are not covered must have PR comments explaining why they cannot be covered. For example, "Reaching this particular exception is hard and is not a particular common scenario."
  • Enable "Allow edits from maintainers".

Copy link

gsmet commented May 30, 2022

Thanks @yusuf-erdem. Any chance you could also add the other fields they recently added?

  "runner_id": 1,
  "runner_name": "my runner",
  "runner_group_id": 2,
  "runner_group_name": "my runner group"

See the example response here: .

Copy link
Contributor Author

Thanks @yusuf-erdem. Any chance you could also add the other fields they recently added?

  "runner_id": 1,
  "runner_name": "my runner",
  "runner_group_id": 2,
  "runner_group_name": "my runner group"

See the example response here: .


@yusuf-erdem yusuf-erdem changed the title Add labels property to the Add missing porperties to the May 30, 2022
Copy link

codecov bot commented May 30, 2022

Codecov Report

Merging #1447 (f6674a9) into main (7a16c30) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #1447      +/-   ##
+ Coverage     78.74%   78.76%   +0.01%     
- Complexity     2102     2107       +5     
  Files           201      201              
  Lines          6404     6410       +6     
  Branches        361      361              
+ Hits           5043     5049       +6     
  Misses         1151     1151              
  Partials        210      210              
Impacted Files Coverage Δ
...rc/main/java/org/kohsuke/github/ 91.42% <100.00%> (+1.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a16c30...f6674a9. Read the comment docs.

@bitwiseman bitwiseman merged commit b3bd41b into hub4j:main Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Missing Workflow Job's running machine type (ubuntu, windows, macos)
3 participants