-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shorten test resource paths #1743
Merged
bitwiseman
merged 10 commits into
hub4j:main
from
bitwiseman:shorten-test-resource-paths
Nov 17, 2023
Merged
Shorten test resource paths #1743
bitwiseman
merged 10 commits into
hub4j:main
from
bitwiseman:shorten-test-resource-paths
Nov 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fecb500
to
f69b7af
Compare
f69b7af
to
ba65bfa
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1743 +/- ##
=========================================
Coverage 80.16% 80.16%
Complexity 2301 2301
=========================================
Files 217 217
Lines 6962 6962
Branches 371 371
=========================================
Hits 5581 5581
Misses 1150 1150
Partials 231 231 ☔ View full report in Codecov by Sentry. |
a0abcf5
to
885e60e
Compare
885e60e
to
c8033a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Occasionally we have run into file path length errors on windows. Dealing with these in a one off way is annoying and often happens to new contributors.
This change alters the file names generated when taking snapshots and back ports that format to existing tests.
Before submitting a PR:
@link
JavaDoc entries to the relevant documentation on https://docs.github.com/en/rest .mvn -D enable-ci clean install site
locally. If this command doesn't succeed, your change will not pass CI.main
. You will create your PR from that branch.When creating a PR: