Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorten test resource paths #1743

Merged
merged 10 commits into from
Nov 17, 2023

Conversation

bitwiseman
Copy link
Member

Description

Occasionally we have run into file path length errors on windows. Dealing with these in a one off way is annoying and often happens to new contributors.

This change alters the file names generated when taking snapshots and back ports that format to existing tests.

Before submitting a PR:

  • Changes must not break binary backwards compatibility. If you are unclear on how to make the change you think is needed while maintaining backward compatibility, CONTRIBUTING.md for details.
  • Add JavaDocs and other comments explaining the behavior.
  • When adding or updating methods that fetch entities, add @link JavaDoc entries to the relevant documentation on https://docs.github.com/en/rest .
  • Add tests that cover any added or changed code. This generally requires capturing snapshot test data. See CONTRIBUTING.md for details.
  • Run mvn -D enable-ci clean install site locally. If this command doesn't succeed, your change will not pass CI.
  • Push your changes to a branch other than main. You will create your PR from that branch.

When creating a PR:

  • Fill in the "Description" above with clear summary of the changes. This includes:
    • If this PR fixes one or more issues, include "Fixes #" lines for each issue.
    • Provide links to relevant documentation on https://docs.github.com/en/rest where possible. If not including links, explain why not.
  • All lines of new code should be covered by tests as reported by code coverage. Any lines that are not covered must have PR comments explaining why they cannot be covered. For example, "Reaching this particular exception is hard and is not a particular common scenario."
  • Enable "Allow edits from maintainers".

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9ff3264) 80.16% compared to head (885e60e) 80.16%.

❗ Current head 885e60e differs from pull request most recent head c8033a9. Consider uploading reports for the commit c8033a9 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1743   +/-   ##
=========================================
  Coverage     80.16%   80.16%           
  Complexity     2301     2301           
=========================================
  Files           217      217           
  Lines          6962     6962           
  Branches        371      371           
=========================================
  Hits           5581     5581           
  Misses         1150     1150           
  Partials        231      231           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bitwiseman bitwiseman merged commit 40992f7 into hub4j:main Nov 17, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant