Remove many but not all deprecated classes and methods #1757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitwiseman
force-pushed
the
feature/2.x
branch
from
5a453e0
to
6994e1c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main-2.x #1757 +/- ##
===========================================
Coverage ? 79.15%
Complexity ? 2179
===========================================
Files ? 215
Lines ? 6807
Branches ? 360
===========================================
Hits ? 5388
Misses ? 1187
Partials ? 232 ☔ View full report in Codecov by Sentry. |
bitwiseman
commented
Nov 30, 2023
Comment on lines
-4
to
5
| <artifactId>github-api</artifactId> | ||
| <artifactId>github-api2</artifactId> | ||
| <version>2.0-alpha1-SNAPSHOT</version> |
There was a problem hiding this comment.
Putting these changes into a new artifact and designating alpha1. No backward compatibility guarantees.
bitwiseman
commented
Nov 30, 2023
Comment on lines
-603
to
-616
| <!-- This is the last version of okhttp3 that support UrlConnection --> | ||
| <!-- The class using this has been deprecated, this dependency can be remove when that class is. --> | ||
| <dependency> | ||
| <groupId>com.squareup.okhttp3</groupId> | ||
| <artifactId>okhttp-urlconnection</artifactId> | ||
| <version>3.12.3</version> | ||
| <optional>true</optional> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>com.squareup.okhttp</groupId> | ||
| <artifactId>okhttp-urlconnection</artifactId> | ||
| <version>2.7.5</version> | ||
| <optional>true</optional> | ||
| </dependency> |
There was a problem hiding this comment.
Omg. At long last. Good bye.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before submitting a PR:
@linkJavaDoc entries to the relevant documentation on https://docs.github.com/en/rest .mvn -D enable-ci clean install sitelocally. If this command doesn't succeed, your change will not pass CI.main. You will create your PR from that branch.When creating a PR: