update branch & change base on PRs #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tginiotis-at-work
force-pushed
the
pr_updates
branch
3 times, most recently
from
73e7c99
to
7f7c61d
Compare
tginiotis-at-work
force-pushed
the
pr_updates
branch
from
7f7c61d
to
4b9df79
Compare
bitwiseman
reviewed
Aug 13, 2020
bitwiseman
reviewed
Aug 13, 2020
bitwiseman
requested changes
Aug 13, 2020
|
@tginiotis-at-work |
|
@bitwiseman Hey, yes. I was a bit busy with other stuff, but I will look into these this week. |
tginiotis-at-work
force-pushed
the
pr_updates
branch
from
4b9df79
to
4a0d754
Compare
tginiotis-at-work
force-pushed
the
pr_updates
branch
from
4a0d754
to
de39513
Compare
|
I have added cases for when the base branch does not exist and when the How does it look now? |
tginiotis-at-work
force-pushed
the
pr_updates
branch
from
de39513
to
5d7479a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding a method to update the PR branch from the base branch & a method to change the base of the PR.
Closes #787.
Before submitting a PR:
We love getting PRs, but we hate asking people for the same basic changes every time.
master. Create your PR from that branch.mvn clean compilelocally. This may reformat your code, commit those changes.mvn -D enable-ci clean install sitelocally. If this command doesn't succeed, your change will not pass CI.When creating a PR: