List team members by role #950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tginiotis-at-work
force-pushed
the
listTeamMembers
branch
from
ca7c568
to
1c07742
Compare
bitwiseman
requested changes
Nov 3, 2020
Comment on lines
173
to
174
| public PagedIterable<GHUser> listMembers() throws IOException { | ||
| return root.createRequest().withUrlPath(api("/members")).toIterable(GHUser[].class, item -> item.wrapUp(root)); |
There was a problem hiding this comment.
This is an API change. Please retain the existing public method.
There was a problem hiding this comment.
I have readded the original public method.
| * @throws IOException | ||
| * the io exception | ||
| */ | ||
| public PagedIterable<GHUser> listMembersWithRole(String role) throws IOException { |
There was a problem hiding this comment.
Suggested change
| public PagedIterable<GHUser> listMembersWithRole(String role) throws IOException { | |
| public PagedIterable<GHUser> listMembers(String role) throws IOException { |
There was a problem hiding this comment.
I have renamed the method.
tginiotis-at-work
force-pushed
the
listTeamMembers
branch
from
1c07742
to
7b900e2
Compare
tginiotis-at-work
force-pushed
the
listTeamMembers
branch
from
7b900e2
to
86f64e8
Compare
tginiotis-at-work
force-pushed
the
listTeamMembers
branch
from
86f64e8
to
a800c19
Compare
tginiotis-at-work
force-pushed
the
listTeamMembers
branch
from
a800c19
to
9d161b2
Compare
bitwiseman
approved these changes
Nov 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrades the listing method to also take a role.
Closes #926.
Before submitting a PR:
We love getting PRs, but we hate asking people for the same basic changes every time.
master. Create your PR from that branch.mvn clean compilelocally. This may reformat your code, commit those changes.mvn -D enable-ci clean install sitelocally. If this command doesn't succeed, your change will not pass CI.When creating a PR: