Remove pest, use hand-written parsing instead. #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
I don't really know how to use
pest
, and while there are some intricacies to theauthorized_keys
format (which is why this crate exists), they don't require recursive parsing or other truly tricky usecases.Outcome
Parsing speeds have improved by approximately an order of magnitude, as per
criterion
output. All the tests still pass (and one extra has been added to catch a particular possible error case).