Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Riemann exporter #21

Closed
bpetit opened this issue Dec 1, 2020 · 9 comments
Closed

Riemann exporter #21

bpetit opened this issue Dec 1, 2020 · 9 comments
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects

Comments

@bpetit
Copy link
Contributor

bpetit commented Dec 1, 2020

It's TCP and protocol buffers, should be okay: http://riemann.io/howto.html#write-a-client

@bpetit bpetit created this issue from a note in General (Triage) Dec 1, 2020
@bpetit bpetit added the enhancement New feature or request label Dec 1, 2020
@bpetit bpetit added this to the Release v0.2.0 milestone Dec 1, 2020
@bpetit bpetit added the help wanted Extra attention is needed label Dec 1, 2020
@uggla
Copy link
Collaborator

uggla commented Dec 14, 2020

May I suggest https://github.com/mcorbin/riemann-rust-client
Mathieu (mcorbin) is available on the "compagnon du devops" forum and may help in Rust and Clojure.

Or https://github.com/borntyping/rust-riemann_client which looks completed

@bpetit
Copy link
Contributor Author

bpetit commented Dec 15, 2020

Of course you can. Thanks a lot for those hints. I'll try to create some interest in Mathieu's mind about scaphandre so that he gives us some help regarding that feature then :D

@uggla
Copy link
Collaborator

uggla commented Jan 2, 2021

@bpetit, I have made a quick test with the rust-riemann_client and it works fine. By the way I have discovered riemann that I never used before.
The client looks pretty simple to use.
So if it ok for you I can take this issue and create the riemann exporter trying to mimic what you did with the prom one.

@bpetit
Copy link
Contributor Author

bpetit commented Jan 3, 2021

Hi, of course ! Give it a try !

The prom exporter code may be useful about getting metrics from the sensor, but I guess it won't be regarding the way to ship the metrics, as it should be a push mode here instead of a pull one.

(Just remember that it's the exporter that asks the sensor to collect and store metrics, so you are in control regarding the periodicity and conditions of metrics storage in the buffers and their usage afterwards.)

@uggla
Copy link
Collaborator

uggla commented Jan 5, 2021

@bpetit, FYI, I made good progress on that topic. Normally, I will be able to send you a PR soon.

@bpetit bpetit moved this from Triage to In progress in General Jan 6, 2021
@uggla
Copy link
Collaborator

uggla commented Jan 10, 2021

@bpetit, progressing, I'm just missing the processes values now.
I had a lot of work last week, so I could not finish it. I hope I will manage to progress this week and get a first version.
image

@bpetit
Copy link
Contributor Author

bpetit commented Jan 11, 2021

This is great ! Thanks a lot for the great work 😃
No worries, that's perfect anyway. I'm very excited about using that feature !

@uggla
Copy link
Collaborator

uggla commented Jan 17, 2021

Please look at #58

@bpetit
Copy link
Contributor Author

bpetit commented Jan 29, 2021

Done and merged. Thanks a lot @uggla !

@bpetit bpetit closed this as completed Jan 29, 2021
General automation moved this from In progress to Done Jan 29, 2021
@bpetit bpetit moved this from Done to Previous releases in General Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
General
Previous releases
Development

No branches or pull requests

2 participants