Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement --containers option in json exporter #217

Closed
bpetit opened this issue Sep 22, 2022 · 3 comments · Fixed by #231
Closed

Implement --containers option in json exporter #217

bpetit opened this issue Sep 22, 2022 · 3 comments · Fixed by #231
Labels
enhancement New feature or request
Projects

Comments

@bpetit
Copy link
Contributor

bpetit commented Sep 22, 2022

Problem

I'd like to get container labels to metrics I get from json exporter, but the option doesn't exist yet, like it does in prometheus container.

Solution

Implement the --containers option in json exporter.

@bpetit bpetit added the enhancement New feature or request label Sep 22, 2022
@bpetit bpetit added this to the Release v0.5.0 milestone Sep 22, 2022
@bpetit bpetit added this to To do in General Sep 22, 2022
@bpetit bpetit moved this from To do to In progress in General Oct 10, 2022
@bpetit
Copy link
Contributor Author

bpetit commented Oct 28, 2022

Example of usage

scaphandre --no-header json --containers --max-top-consumers=15 | jq

@bpetit bpetit closed this as completed Oct 28, 2022
General automation moved this from In progress to Done Oct 28, 2022
@hrexha28
Copy link

Hi,
I tried to use the --containers option with lxd containers but i get null in the container field for the json exorter.
Is there any way to get the linux container power number?
Thanks

@bpetit
Copy link
Contributor Author

bpetit commented Jan 25, 2023

@hrexha28 I've seen your issue, thanks. Will have a look at this for next releases.

@bpetit bpetit moved this from Done to Previous releases in General Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
General
Previous releases
Development

Successfully merging a pull request may close this issue.

2 participants