Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share of fees at settlement to be split with PartnerFund #175

Closed
jijordre opened this issue Sep 8, 2018 · 1 comment
Closed

Share of fees at settlement to be split with PartnerFund #175

jijordre opened this issue Sep 8, 2018 · 1 comment
Assignees

Comments

@jijordre
Copy link
Contributor

jijordre commented Sep 8, 2018

Description

It is beneficial to a allow partners to charge extra fees on top of Hubii's fees applied to trades and payments.

The first half of the implementation was described in #54. The suggested second half of the implementation describes updated schema of order, trade and payment. It also includes the interaction with new contract called PartnerFund during the settlement of driips in Exchange contract

  1. Order and payment as created in partner nahmii client will have new property of partnerTag (e.g. bytes32 type). This tag will be unique per partner. Trade will include partner tags for buy and sell orders in the respective order sub-documents. partnerTag will be included in hashes of orders and payments. Default value of partnerTag as produced by Core/SDK will be 0x0.
  2. Exchange contracts will transfer Hubii's share of fee to RevenueFund contract as currently implemented. In addition partner's fee will be transferred to new PartnerFund contract (see below.)

Definition of done

  • Schemas have been updated
  • Exchange contract have been updated
  • Unit tests have been implemented/updated

Details & Questions

This issue was created based on the following description by @markbkk:

The ability for us to add an "additional partner specified fee" over and above the based striim fee. I believe this should be expressed as an additional % over the main fee combined with volume discounts. So if partner P wants to charge double the fee as Striim itself does, then they would set a figure of 200%. If striim was charging "0.1% - volume discount" for a payment of 1,000 ETH, then partner P would add on 200% and so the overall fee would be "(1 + 200%) * (0.1% - volume discount)".

Depends on

@jijordre jijordre added this to To do in nahmii contracts via automation Sep 8, 2018
@jijordre jijordre moved this from To do to In progress in nahmii contracts Nov 25, 2018
@jijordre jijordre self-assigned this Nov 25, 2018
@jijordre jijordre mentioned this issue Nov 25, 2018
@jijordre jijordre moved this from In progress to In Review in nahmii contracts Dec 6, 2018
@jijordre
Copy link
Contributor Author

jijordre commented Dec 6, 2018

Closed by #254.

@jijordre jijordre closed this as completed Dec 6, 2018
nahmii contracts automation moved this from In Review to Done Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

1 participant