You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As currently implemented it is possible to start a DSC on a trade and propose stage amount(s) of 0. However, when settling this trade the settlement call fails. The reason being that ClientFund.stage() is set to revert with stage amount that is not strictly positive.
This issue describes the enablement of settlement of trade whose DSC proposes stage amount(s) of 0. This can be done by only calling ClientFund.stage() when the respective stage amount is strictly positive.
Description
As currently implemented it is possible to start a DSC on a trade and propose stage amount(s) of 0. However, when settling this trade the settlement call fails. The reason being that
ClientFund.stage()
is set to revert with stage amount that is not strictly positive.This issue describes the enablement of settlement of trade whose DSC proposes stage amount(s) of 0. This can be done by only calling
ClientFund.stage()
when the respective stage amount is strictly positive.Definition of done
Details & Questions
Depends on
The text was updated successfully, but these errors were encountered: