Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable settlement of trade whose DSC has 0 stage amount(s) #450

Open
jijordre opened this issue Oct 22, 2019 · 0 comments
Open

Enable settlement of trade whose DSC has 0 stage amount(s) #450

jijordre opened this issue Oct 22, 2019 · 0 comments

Comments

@jijordre
Copy link
Contributor

Description

As currently implemented it is possible to start a DSC on a trade and propose stage amount(s) of 0. However, when settling this trade the settlement call fails. The reason being that ClientFund.stage() is set to revert with stage amount that is not strictly positive.

This issue describes the enablement of settlement of trade whose DSC proposes stage amount(s) of 0. This can be done by only calling ClientFund.stage() when the respective stage amount is strictly positive.

Definition of done

  • DriipSettlementByTrade has been updated
  • Unit tests have been updated

Details & Questions

Depends on

@jijordre jijordre added this to To do in nahmii contracts via automation Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

1 participant