Optimization of NahmiiToken transfers

[jijordre]

Description

With the current implementation of NahmiiToken the gas of an invocation of transfer() or transferFrom() is of the order of 250k. This number should be contrasted with transfer costs of other comparable ERC20 tokens whose gas cost often times is in the range from 50k to 100k, or even below this range.

This issue describes the optimization of transfer of NahmiiToken w.r.t. gas cost. It is suggested that its store of balance blocks and holders is removed. The former requires an update of the balance blocks calculation given a span of block numbers so that a balance bin's value of balance blocks be calculated on the fly at claim time. The latter feature is deemed not needed in the contract as the set of holders may be obtained from other sources off-chain.

In the context of updating the balance blocks calculations it is suggested that the calculation itself be delegated to separate contract outside of NahmiiToken. This allows for code reuse as the same logics is also used in the current implementation of TokenHolderRevenueFund to obtain released amount blocks.

Definition of done

• NahmiiToken has been updated
• TokenHolderRevenueFund has been updated
• RevenueTokenManager has been updated
• Unit tests have been updated

Details & Questions

Depends on