Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump vitessce version #2991

Merged
merged 9 commits into from
Mar 26, 2023
Merged

Bump vitessce version #2991

merged 9 commits into from
Mar 26, 2023

Conversation

keller-mark
Copy link
Member

No description provided.

@keller-mark keller-mark marked this pull request as ready for review January 5, 2023 21:39
Copy link
Collaborator

@john-conroy john-conroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Seems like we're missing a dependency of react-test-renderer and it's surfacing here for some reason. Could you install it as a dev dependency and see if it resolves the issue with ci?

Outside of that, everything looks good. I think Chuck primarily reviewed these version bumps in the past so if there are things I should be looking at outside of the diffs in portal-ui, let me know.

@ilan-gold
Copy link
Member

I'm looking @john-conroy, no worries.

@ilan-gold
Copy link
Member

Screen Shot 2023-01-08 at 1 58 34 PM

was flipping the order of segmentation and raster in the controller intentional? genuinely don't know but i also don't think it should block.

@ilan-gold
Copy link
Member

ilan-gold commented Jan 8, 2023

Filed vitessce/vitessce#1381 but definitely not a blocker.

@john-conroy john-conroy merged commit 2bf6311 into main Mar 26, 2023
@john-conroy john-conroy deleted the keller-mark/vitessce-2.x branch March 26, 2023 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants