Adds health checking to the board loading sequence #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,50 @@ | |||
| module HealthChecker | |||
| module HealthChecks | |||
| class GitHubRepoWebhooks | |||
There was a problem hiding this comment.
Suffix the check classes with Check so they are easy to search for
|
|
||
| #Supports carrying over DSL attributes to the instantiated | ||
| #parent class | ||
| def initialize |
There was a problem hiding this comment.
initialize logic added by modules seems dangerous.
I can think of few libraries that do it but it's always been weird to track it down.
It's just my gut, I'm willing to be wrong
… initializing instance vars and calling super
…weaks a payload mispell
…in another PR should be used on trials)
… autoload problems
…es if you are logged in, thats the concern of the health check
|
Needs UI work |
rauhryan
changed the title
Conflicts: Gemfile.lock config/routes.rb
Conflicts: config/routes.rb ember-app/app/routes/application.js
|
a wild design appears
General idea being there will be a health check section for each linked repo, the fix it button will attempt to fix the issue |
|
Pretty happy with this as a good look and feel
|
|
|
||
| var Health = Settings.extend({ | ||
| repo: {}, | ||
| storageKey: Ember.computed('repo.data.repo.full_name',{ |
There was a problem hiding this comment.
Cool! For troubleshooting convenience, we should may add a refresh button that refetches all the checks ?
makes health checks linked repo aware
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HealthChecking lib for the back-end, comprised of DSL style 'health checks' that respond to
perform