Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃敀 NPM audit fix --force to pick up Redis security fix #40

Merged
merged 2 commits into from May 17, 2021

Conversation

xurizaemon
Copy link
Contributor

@xurizaemon xurizaemon commented May 6, 2021

@hubotio seems a bit unmaintained, but I am gonna throw this drive-by PR up in case it gets merged to fix a recent advisory for the redis package.

don't start using my fork tho, it's already abandoned 馃槈

@stephenyeargin
Copy link

@technicalpickles This looks like it will help folks clear a Security Alert. Can it get a 馃憤?

(Tests are failing because Travis is configured to use legacy versions of Node.)

@xurizaemon xurizaemon changed the title 馃敀 NPM audit fix --force 馃敀 NPM audit fix --force to pick up Redis security fix May 17, 2021
@mistydemeo
Copy link
Contributor

Sorry I missed this. Looks like I wasn't watching the repo. I'll fix CI first, then we can merge this.

@mistydemeo
Copy link
Contributor

Thank you so much for your PR! It's greatly appreciated. People like you help keep OSS running.

@mistydemeo mistydemeo merged commit 2ab8963 into hubotio:master May 17, 2021
@mistydemeo
Copy link
Contributor

I'll look at cutting a new release soon.

@xurizaemon xurizaemon deleted the npm_audit_fix_force branch May 17, 2021 23:51
@xurizaemon
Copy link
Contributor Author

Thankyou! Much appreciated 馃榿

@xurizaemon
Copy link
Contributor Author

Hi @mistydemeo, any chance we could ship a release with this fix? 1.0.0 is latest and it's from 2017.

https://www.npmjs.com/package/hubot-redis-brain

@github-actions
Copy link

馃帀 This PR is included in version 1.1.0 馃帀

The release is available on:

Your semantic-release bot 馃摝馃殌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants