Update to use for x in y instead of forEach

src/hubot/campfire.coffee

@@ -4,14 +4,13 @@ EventEmitter = require("events").EventEmitter
 
 class Campfire extends Robot
   send: (user, strings...) ->
-    strings.forEach (str) =>
+    for str in strings
       @bot.Room(user.room).speak str, (err, data) ->
         if err
           console.log "campfire error: #{err}"
 
   reply: (user, strings...) ->
-    strings.forEach (str) =>
-      @send user, "#{user.name}: #{str}"
+      @send user, "#{user.name}: #{str}" for str in strings
 
   run: ->
     self = @

src/hubot/irc.coffee

@@ -3,12 +3,12 @@ Irc   = require "irc"
 
 class IrcBot extends Robot
   send: (user, strings...) ->
-    strings.forEach (str) =>
+    for str in strings
       console.log "#{user.name}: #{str}"
       @bot.say(user.room, str)
 
   reply: (user, strings...) ->
-    strings.forEach (str) =>
+    for str in strings
       @send user, "#{user.name}: #{str}"
 
   run: ->

src/hubot/scripts/roles.coffee

@@ -38,7 +38,7 @@ module.exports = (robot) ->
             msg.send "I know"
           else
             user.roles.push(newRole)
-            if name.toLowerCase() == robot.name
+            if name.toLowerCase() is robot.name
               msg.send "Ok, I am #{newRole}."
             else
               msg.send "Ok, #{name} is #{newRole}."

src/hubot/shell.coffee

@@ -2,11 +2,11 @@ Robot = require 'robot'
 
 class Shell extends Robot
   send: (user, strings...) ->
-    strings.forEach (str) ->
+    for str in strings
       console.log str
 
   reply: (user, strings...) ->
-    strings.forEach (str) =>
+    for str in strings
       @send user, "#{user.name}: #{str}"
 
   run: ->

src/robot.coffee

@@ -59,7 +59,7 @@ class Robot
   #
   # Returns nothing.
   receive: (message) ->
-    @listeners.forEach (lst) -> lst.call message
+    listener.call message for listener in @listeners
 
   # Public: Loads every script in the given path.
   #
@@ -70,7 +70,7 @@ class Robot
     Path.exists path, (exists) =>
       if exists
         @loadPaths.push path
-        Fs.readdirSync(path).forEach (file) =>
+        for file in Fs.readdirSync(path)
           @loadFile path, file
 
   # Public: Loads a file in path