Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: is not a function in CatchAll listener #1720

Merged
merged 1 commit into from Apr 5, 2024
Merged

Conversation

joeyguerra
Copy link
Member

@joeyguerra joeyguerra commented Apr 5, 2024

fixes #1721

@joeyguerra joeyguerra merged commit f212f5d into main Apr 5, 2024
6 checks passed
@joeyguerra joeyguerra deleted the missing-reply branch April 5, 2024 15:18
Copy link

github-actions bot commented Apr 5, 2024

🎉 This PR is included in version 11.1.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@PColuccio
Copy link

@joeyguerra I don't believe the msg.message object will be what you expect in this case though. In the original Hubot they were replacing the msg.message with msg.message.message although I haven't dug in to find the reason.

@joeyguerra
Copy link
Member Author

msg is a response. msg.message is an instance of CatchAllMessage. msg.message.message is an instance of TextMessage. Do you think you can try it? I assume you were getting errors in your code, and that led you to submitting a fix?

@joeyguerra joeyguerra restored the missing-reply branch April 18, 2024 21:39
@joeyguerra joeyguerra deleted the missing-reply branch April 18, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

response.reply is not a function in CatchAll listener
2 participants